FIX: Deployed Matlab applications must not call addpath() #3509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
changed the title
https://mathworks.com/help/compiler/isdeployed.html The path of a deployed application is fixed at compile time and cannot change. Use isdeployed to ensure that the application uses path modifying functions, such as addpath, before deployment. This fixes the case where nipype calls SPM12 Standalone, associated to Matlab Compiler Runtime (MCR) R2019a (9.6) or later. Upcoming versions of SPM12 Standalone will most probably be compiled with Matlab R2021b, and hence will be subject to this bug.
DimitriPapadopoulos
force-pushed
the
spm12_standalone
branch
from
090165e to
a101d24
Compare
Codecov ReportBase: 65.26% // Head: 65.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3509 +/- ##
=======================================
Coverage 65.26% 65.26%
=======================================
Files 309 309
Lines 40870 40870
Branches 5380 5380
=======================================
Hits 26672 26672
Misses 13124 13124
Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://mathworks.com/help/compiler/isdeployed.html
As suggested by @servoz, this fixes the case where nipype calls SPM12 Standalone, associated to Matlab Compiler Runtime (MCR) R2019a (9.6) or later. Upcoming versions of SPM12 Standalone will most probably be compiled with Matlab R2021b, and hence will be subject to this bug.
Fixes #3507.
List of changes proposed in this PR (pull-request)
addpathin Matlab scripts called from a deployed Matlab application.